Add new GameServer lifecycle diagrams for Reserved #922
Conversation
markmandel
added
kind/feature
|
Build Succeeded 👏 Build Id: 868fd8c3-7126-4217-933e-ea9b3d30ae71 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
build/Makefile
Outdated
| @@ -392,8 +392,6 @@ gen-crd-client: $(ensure-build-image) | |||
| docker run --rm $(common_mounts) -w $(workdir_path) $(build_tag) /root/gen-crd-client.sh | |||
| docker run --rm $(common_mounts) -w $(workdir_path)/pkg $(build_tag) goimports -w . | |||
|
|
|||
| site-images: $(site_path)/static/diagrams/gameserver-states.dot.png $(site_path)/static/diagrams/gameserver-lifecycle.puml.png | |||
|
|
|||
| # generate pngs from dot files | |||
There was a problem hiding this comment.
Should this part of the makefile move as well? Are there places outside of the website where we generate pngs from dot files and puml files?
There was a problem hiding this comment.
That is true that we don't - but it seemed general enough that maybe leave it where it was.
Honestly, I've no strong opinion on this, so if you feel strongly, I'll move it.
There was a problem hiding this comment.
If we are still thinking about moving the website to a different repo after 1.0 I'd move it to the site makefile now to make that simpler.
There was a problem hiding this comment.
Makes perfect sense. Will make the move 👍
markmandel
force-pushed
the
docs/reserved-lifecycle
branch
from
01846eb
to
b208324
Compare
|
Changes made, per comments 👍 |
|
Build Failed 😱 Build Id: f66bebb1-738a-49dd-9da2-a888ddc9da61 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: ccd1d977-9a1c-4da8-a6d7-64ea677b079d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Shows how the workflow can exist for 1st party/distributed matchmakers. Work on googleforgames#660
markmandel
force-pushed
the
docs/reserved-lifecycle
branch
from
b208324
to
2110e6b
Compare
|
Build Succeeded 👏 Build Id: 1f560c92-fe89-48ac-9e71-a42bf22f66b0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: 5fb037d1-7aac-4c67-a8af-c2e853333482 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: 3bc89139-6e83-4cbf-88c6-b6d810487f74 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Shows how the workflow can exist for 1st party/distributed matchmakers.
Work on #660